Consider macOS to be fully supported #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't this mean that even if someone is not using |
godlygeek
force-pushed
the
macos_warn_at_import_time
branch
from
cd0b47d
to
5b9e413
Compare
Looks like yes - though |
1 task
godlygeek
force-pushed
the
macos_warn_at_import_time
branch
from
5b9e413
to
e71aea6
Compare
|
After some offline discussions, we've decided to drop the warning entirely, and to consider macOS to be fully supported rather than experimental. |
godlygeek
changed the title
Previously this warning would be printed each time a `Tracker` was constructed, which caused a lot of noise when `pytest-memray` was being used, since it creates one `Tracker` per pytest test. Since we haven't heard any reports from users of any cases where things are actually broken on macOS, and since our documentation lists all of the known limitations in considerable detail, we've decided to stop considering macOS support to be experimental, and to drop the warning. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
macos_warn_at_import_time
branch
from
e71aea6
to
3a776ef
Compare
pablogsal
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this warning would be printed each time a
Trackerwas constructed, which caused a lot of noise whenpytest-memraywas being used, since it creates oneTrackerper pytest test. Now it will only be printed at most once per Python interpreter run.Signed-off-by: Matt Wozniski mwozniski@bloomberg.net
Closes #194